This is a note to let you know that I've just added the patch titled USB: keyspan: fix null-deref at disconnect and release to the 3.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-keyspan-fix-null-deref-at-disconnect-and-release.patch and it can be found in the queue-3.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 8ab959a23fae461cf05093cfd5b0e6ebdc50aa87 Mon Sep 17 00:00:00 2001 From: Johan Hovold <jhovold@xxxxxxxxx> Date: Tue, 13 Aug 2013 13:27:35 +0200 Subject: USB: keyspan: fix null-deref at disconnect and release From: Johan Hovold <jhovold@xxxxxxxxx> commit ff8a43c10f1440f07a5faca0c1556921259f7f76 upstream. Make sure to fail properly if the device is not accepted during attach in order to avoid null-pointer derefs (of missing interface private data) at disconnect or release. Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> Cc: Yang Yingliang <yangyingliang@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/usb/serial/keyspan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/serial/keyspan.c +++ b/drivers/usb/serial/keyspan.c @@ -2486,7 +2486,7 @@ static int keyspan_startup(struct usb_se if (d_details == NULL) { dev_err(&serial->dev->dev, "%s - unknown product id %x\n", __func__, le16_to_cpu(serial->dev->descriptor.idProduct)); - return 1; + return -ENODEV; } /* Setup private data for serial driver */ Patches currently in stable-queue which might be from jhovold@xxxxxxxxx are queue-3.4/usb-mos7840-fix-memory-leak-in-open.patch queue-3.4/usb-oti6858-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-io_ti-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-pl2303-fix-device-initialisation-at-open.patch queue-3.4/usb-ch341-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-io_edgeport-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-ftdi_sio-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-ark3116-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-pl2303-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-cypress_m8-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-ssu100-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-keyspan-fix-null-deref-at-disconnect-and-release.patch queue-3.4/usb-mct_u232-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-spcp8x5-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-adutux-fix-big-endian-device-type-reporting.patch queue-3.4/usb-ti_usb_3410_5052-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-spcp8x5-fix-device-initialisation-at-open.patch queue-3.4/usb-mos7840-fix-race-in-register-handling.patch queue-3.4/usb-ftdi_sio-fixed-handling-of-unsupported-csize-setting.patch queue-3.4/usb-mos7840-fix-broken-tiocmiwait.patch queue-3.4/usb-serial-fix-hang-when-opening-port.patch queue-3.4/usb-mos7840-fix-use-after-free-in-tiocmiwait.patch queue-3.4/usb-ti_usb_3410_5052-fix-big-endian-firmware-handling.patch queue-3.4/usb-serial-add-modem-status-change-wait-queue.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html