On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > introduced the following build error:
> >
> > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> > 304 | .vm_ops = &drm_gem_cma_vm_ops,
> > | ^~~~~~~~~~~~~~~~~~
> > | drm_gem_mmap_obj
> >
> > Fixed by adding missing include file.
> >
> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Didn't you review exactly this change yesterday? Anyway, you should add
Yep.
>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>
> and
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
>
> It might happen that I land my patch first, depending on the urgency of
> the issue.
I expect you to land the patch you made asap so we can have the build
fixed again.
Sam
