On 2020/9/23 16:43, Christoph Hellwig wrote: > On Wed, Aug 19, 2020 at 12:22:05PM +0800, Coly Li wrote: >> On 2020/8/19 03:49, Christoph Hellwig wrote: >>> On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote: >>>> On 2020/8/19 00:24, Christoph Hellwig wrote: >>>>> I think we should go for something simple like this instead: >>>> >>>> This idea is fine to me. Should a warning message be through here? IMHO >>>> the driver still sends an improper page in, fix it in silence is too >>>> kind or over nice to the buggy driver(s). >>> >>> I don't think a warning is a good idea. An API that does the right >>> thing underneath and doesn't require boiler plate code in most callers >>> is the right API. >>> >> >> Then I don't have more comment. > > So given the feedback from Dave I suspect we should actually resurrect > this series, sorry for the noise. And in this case I think we do need > the warning in kernel_sendpage. > Copied, then I will post a v8 series, which adding a warning message in kernel_sendpage() if non-acceptible paage sent in. Coly Li
