On Tue, 2014-04-01 at 14:31 +0800, Rui Xiang wrote:
> On 2014/3/24 20:28, Ben Hutchings wrote:
> > On Mon, 2014-03-24 at 20:13 +0800, Rui Xiang wrote:
> >> From: Shiva Krishna Merla <shivakrishna.merla@xxxxxxxxxx>
> >>
> >> commit 954a73d5d3073df2231820c718fdd2f18b0fe4c9 upstream.
> > [...]
> >> [switch to disabling pg_init in flush_multipath_work & header edits by Mike Snitzer]
> >> Signed-off-by: Shiva Krishna Merla <shivakrishna.merla@xxxxxxxxxx>
> >> Reviewed-by: Krishnasamy Somasundaram <somasundaram.krishnasamy@xxxxxxxxxx>
> >> Tested-by: Speagle Andy <Andy.Speagle@xxxxxxxxxx>
> >> Acked-by: Junichi Nomura <j-nomura@xxxxxxxxxxxxx>
> >> Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
> >> [bwh: Backported to 3.2:
> >> - Adjust context
> >> - Bump version to 1.3.2 not 1.6.0]
> >> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> >> [xr: Backported to 3.4: Bump version to 1.3.1]
> > [...]
> >
> > I think the version should have been bumped to 1.3.1 in commit
> > d8b8a43e0f3c ('dm: fix truncated status strings', commit fd7c092e711e
> > upstream), and that you should bump it to 1.3.2 in this patch, same as I
> > did for 3.2.y.
>
> Hi, Ben
>
> That's true in 3.2.y.
>
> But in commit d8b8a43e0f3c('dm: fix truncated status strings', commit fd7c092e711e
> upstream) for 3.4.y, there wasn't any change for the version. And is it necessary
> to bump the version to 1.3.2 ?
The situation now is:
- Linux 3.2 had dm-mpath version 1.3.0
- Linux 3.2.41 included the backport of 'dm: fix truncated status
strings' and bumped the version to 1.3.1
- Linux 3.2.54 included this fix and bumped the version to 1.3.2
- Linux 3.4 also had dm-path version 1.3.0 (although it isn't *exactly*
the same as the version in Linux 3.2)
- Linux 3.4.73 included the backport of 'dm: fix truncated status
strings', but didn't bump the version as I think it should have
So dm-path labelled as version 1.3.0 may or may not include 'dm: fix
truncated status strings'. I think it is desirable that we avoid the
same ambiguity for versions 1.3.1 and 1.3.2.
Alasdair and Mike, could you comment on this?
Ben.
--
Ben Hutchings
Computers are not intelligent. They only think they are.
Attachment:
signature.asc
Description: This is a digitally signed message part