On 9/6/20 2:51 AM, Souptick Joarder wrote: > There seems to be a bug in the original code when gntdev_get_page() > is called with writeable=true then the page needs to be marked dirty > before being put. > > To address this, a bool writeable is added in gnt_dev_copy_batch, set > it in gntdev_grant_copy_seg() (and drop `writeable` argument to > gntdev_get_page()) and then, based on batch->writeable, use > set_page_dirty_lock(). > > Fixes: a4cdb556cae0 (xen/gntdev: add ioctl for grant copy) > Suggested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx> > Cc: John Hubbard <jhubbard@xxxxxxxxxx> > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> > Cc: Juergen Gross <jgross@xxxxxxxx> > Cc: David Vrabel <david.vrabel@xxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx (can be added at commit time) Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>