Re: [PATCH stable v5.4 1/3] KVM: arm64: Add kvm_extable for vaxoricism code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 01, 2020 at 12:17:54PM +0100, André Przywara wrote:
> On 01/09/2020 12:12, Marc Zyngier wrote:
> > Hi Andre,
> > 
> > On 2020-09-01 10:49, Andre Przywara wrote:
> >> From: James Morse <james.morse@xxxxxxx>
> >>
> >> commit e9ee186bb735bfc17fa81dbc9aebf268aee5b41e upstream.
> >>
> >> KVM has a one instruction window where it will allow an SError exception
> >> to be consumed by the hypervisor without treating it as a hypervisor bug.
> >> This is used to consume asynchronous external abort that were caused by
> >> the guest.
> >>
> >> As we are about to add another location that survives unexpected
> >> exceptions,
> >> generalise this code to make it behave like the host's extable.
> >>
> >> KVM's version has to be mapped to EL2 to be accessible on nVHE systems.
> >>
> >> The SError vaxorcism code is a one instruction window, so has two entries
> >> in the extable. Because the KVM code is copied for VHE and nVHE, we
> >> end up
> >> with four entries, half of which correspond with code that isn't mapped.
> >>
> >> Cc: <stable@xxxxxxxxxxxxxxx> # 5.4.x
> >> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> >> Signed-off-by: James Morse <james.morse@xxxxxxx>
> >> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> > 
> > Can you make sure these patches do carry the sign-off chain as we have
> > in mainline? In particular, this is missing:
> > 
> >     Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx>
> >     Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> > 
> > You can add your own SoB after this.
> 
> Sure, I wasn't sure your review would apply to this version as well. I
> took the backports from James' kernel.org repo, where they were lacking
> any of those tags.
> So shall I copy all the tags from mainline to all backport versions?

Yes.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux