Re: [Cluster-devel] [PATCH] gfs2: Make sure we don't miss any delayed withdraws

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message -----
> Commit ca399c96e96e changes gfs2_log_flush to not withdraw the
> filesystem while holding the log flush lock, but it fails to check if
> the filesystem needs to be withdrawn once the log flush lock has been
> released.  Likewise, commit f05b86db314d depends on gfs2_log_flush to
> trigger for delayed withdraws.  Add that and clean up the code flow
> somewhat.
> 
> In gfs2_put_super, add a check for delayed withdraws that have been
> missed to prevent these kinds of bugs in the future.
> 
> Fixes: ca399c96e96e ("gfs2: flesh out delayed withdraw for gfs2_log_flush")
> Fixes: f05b86db314d ("gfs2: Prepare to withdraw as soon as an IO error occurs
> in log write")
> Cc: stable@xxxxxxxxxxxxxxx # v5.7+
> Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> ---
Looks good.

Reviewed-by: Bob Peterson <rpeterso@xxxxxxxxxx>

Bob Peterson




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux