Re: [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 24, 2020 at 07:31:28PM +0200, Cyril Roelandt wrote:
> This device does not support UAS properly and a similar entry already
> exists in drivers/usb/storage/unusual_uas.h. Without this patch,
> storage_probe() defers the handling of this device to UAS, which cannot
> handle it either.
> 
> Tested-by: Brice Goglin <brice.goglin@xxxxxxxxx>
> CC: <stable@xxxxxxxxxxxxxxx>

You left out the Signed-off-by: tag and a Fixes: tag.  Please resend the 
patch with those tags.  When you do, you may add:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern

> ---
>  drivers/usb/storage/unusual_devs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 220ae2c356ee..5732e9691f08 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2328,7 +2328,7 @@ UNUSUAL_DEV(  0x357d, 0x7788, 0x0114, 0x0114,
>  		"JMicron",
>  		"USB to ATA/ATAPI Bridge",
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> -		US_FL_BROKEN_FUA ),
> +		US_FL_BROKEN_FUA | US_FL_IGNORE_UAS ),
>  
>  /* Reported by Andrey Rahmatullin <wrar@xxxxxxxxxxxx> */
>  UNUSUAL_DEV(  0x4102, 0x1020, 0x0100,  0x0100,
> -- 
> 2.28.0
> 



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux