From: Stephen Boyd <swboyd@xxxxxxxxxxxx> commit 8979ef70850eb469e1094279259d1ef393ffe85f upstream. We get the opp_table pointer at the top of the function and so we should put the pointer at the end of the function like all other exit paths from this function do. Cc: v5.7+ <stable@xxxxxxxxxxxxxxx> # v5.7+ Fixes: aca48b61f963 ("opp: Manage empty OPP tables with clk handle") Reviewed-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> [ Viresh: Split the patch into two ] Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> [ Viresh: Update the code for v5.7-stable ] Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> --- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index bb7060d52eec..c94e725e6522 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -820,7 +820,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) if (opp_table->required_opp_tables) { ret = _set_required_opps(dev, opp_table, NULL); } else if (!_get_opp_count(opp_table)) { - return 0; + ret = 0; } else { dev_err(dev, "target frequency can't be 0\n"); ret = -EINVAL; -- 2.25.0.rc1.19.g042ed3e048af