On Fri, Aug 21, 2020 at 12:06:45PM +0300, Andy Shevchenko wrote: > On Fri, Aug 21, 2020 at 10:26 AM Pavel Machek <pavel@xxxxxxx> wrote: > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > > [ Upstream commit 3d858942250820b9adc35f963a257481d6d4c81d ] > > > > > > The event handler loop must be run with interrupts disabled. > > > Otherwise we will have a warning: > > ... > > > Recently xHCI driver switched to tasklets in the commit 36dc01657b49 > > > ("usb: host: xhci: Support running urb giveback in tasklet > > > context"). > > > > AFAICT, 36dc01657b49 is not included in 4.19.141, so this commit > > should not be needed, either. > > I'm wondering if there are any other USB host controller drivers that > use URB giveback in interrupt enabled context. Almost all do.