Re: [PATCH 1/3] net: asix: handle packets crossing URB boundaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 30, 2014 at 09:28:03PM +0100, Ben Hutchings wrote:
> On Thu, 2014-02-27 at 16:30 +0100, Emil Goode wrote:
> > commit 8b5b6f5413e97c3e8bafcdd67553d508f4f698cd upstream.
> > 
> > ASIX AX88772B started to pack data even more tightly. Packets and the ASIX packet
> > header may now cross URB boundaries. To handle this we have to introduce
> > some state between individual calls to asix_rx_fixup().
> > 
> > Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > [ Emil: backported to 3.2: dropped changes to drivers/net/usb/ax88172a.c ]
> [...]
> 
> You seem to have also combined this with:
> 
> commit bc689c9788f2cc9829d01d84083bc1714b969b15
> Author: stephen hemminger <shemminger@xxxxxxxxxx>
> Date:   Thu Jan 5 19:10:23 2012 +0000
> 
>     usbnet: make ethtool_ops const
> 
> (limited to asix) and:
> 
> commit a9e0aca4b37885b5599e52211f098bd7f565e749
> Author: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Date:   Wed Mar 14 20:18:32 2012 +0000
> 
>     asix: asix_rx_fixup surgery to reduce skb truesizes
> 
> The first is certainly not needed in stable.
> 
> The second is presumably a dependency of this fix, but in that case
> please can you backport it as a separate patch before this?
> 
> Ben.

Hello Ben,

Thank you for pointing this out. I should have realized that this is
obviously why I had to modify the backport more for 3.2 than the other
stable kernels.

I will resend and do some testing.

Best regards,

Emil Goode

> -- 
> Ben Hutchings
> If more than one person is responsible for a bug, no one is at fault.


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]