On Mon, Aug 10, 2020 at 3:33 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Thu, Aug 6, 2020 at 3:39 PM Nathan Huckleberry <nhuck15@xxxxxxxxx> wrote: > > > > Mostly looks good to me. Just a minor nit. > > > > On Thu, Jul 30, 2020 at 3:51 PM Nick Desaulniers > > <ndesaulniers@xxxxxxxxxx> wrote: > > > +/* > > > + * Accessing the address pointed to by the link register triggered an > > > + * exception, don't try to unwind through it. > > > + */ > > > +bad_lr: mov sv_fp, #0 > > > > It might be nice to emit a warning here since we'll > > only hit this case if something fishy is going on > > with the saved lr. > > Yeah, something fishy is going on if that ever happens. Let me create > a V2 with an additional print. FWIW, I ran into another bug on -next when trying to update this. Report: https://lore.kernel.org/lkml/20200811204729.1116341-1-ndesaulniers@xxxxxxxxxx/ Fix: https://lore.kernel.org/lkml/20200814212525.6118-1-john.ogness@xxxxxxxxxxxxx/T/#t Then I got bogged down in planning for plumbers and other fires. I hope to revisit the series after plumbers. -- Thanks, ~Nick Desaulniers
