Re: [PATCH] ALSA: oxygen: Xonar DG(X): capture from I2S channel 1, not 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-03-05 at 22:16 +0100, Clemens Ladisch wrote:
> commit 3dd77654fb1d7f68b9739f3039bad8dbbc0739f8 upstream.
> 
> Actually CS4245 connected to the I2S channel 1 for capture, not channel 2.
> Otherwise capturing and playback does not work for CS4245 because it shuts
> down completely without that I2S clock.
> 
> Signed-off-by: Roman Volkov <v1ron@xxxxxxx>
> Fixes: c386735264da ("ALSA: oxygen: fix Xonar DG input")
> Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> ---

This still didn't apply to 3.2, but I ended up applying the version
below.

Ben.

---
From: Roman Volkov <v1ron@xxxxxxx>
Date: Fri, 24 Jan 2014 16:18:14 +0400
Subject: ALSA: oxygen: Xonar DG(X): capture from I2S channel 1, not 2

commit 3dd77654fb1d7f68b9739f3039bad8dbbc0739f8 upstream.

Actually CS4245 connected to the I2S channel 1 for
capture, not channel 2. Otherwise capturing and
playback does not work for CS4245.

Signed-off-by: Roman Volkov <v1ron@xxxxxxx>
Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
 sound/pci/oxygen/xonar_dg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/pci/oxygen/xonar_dg.c
+++ b/sound/pci/oxygen/xonar_dg.c
@@ -597,7 +597,7 @@ struct oxygen_model model_xonar_dg = {
 	.model_data_size = sizeof(struct dg),
 	.device_config = PLAYBACK_0_TO_I2S |
 			 PLAYBACK_1_TO_SPDIF |
-			 CAPTURE_0_FROM_I2S_2,
+			 CAPTURE_0_FROM_I2S_1,
 	.dac_channels_pcm = 6,
 	.dac_channels_mixer = 0,
 	.function_flags = OXYGEN_FUNCTION_SPI,


-- 
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]