Re: [PATCH-2.6.32.y-3.4.y] staging: comedi: pcmuio: fix possible NULL deref on detach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2013-12-12 at 13:23 +0000, Ian Abbott wrote:
> follow 2fd2bdfccae61efe18f6b92b6a45fbf936d75b48
> 
> pcmuio_detach() is called by the comedi core even if pcmuio_attach()
> returned an error, so `dev->private` might be `NULL`.  Check for that
> before dereferencing it.
> 
> Also, as pointed out by Dan Carpenter, there is no need to check the
> pointer passed to `kfree()` is non-NULL, so remove that check.
> 
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
> ---
> Applies to 2.6.32.y through to 3.4.y inclusive.
> Does not apply to 3.5.y onwards.
[...]

Queued up for 3.2, thanks.

Ben.

-- 
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]