On 8/10/20 9:01 AM, Jens Axboe wrote: > On 8/10/20 5:37 AM, peterz@xxxxxxxxxxxxx wrote: >> On Sat, Aug 08, 2020 at 12:34:38PM -0600, Jens Axboe wrote: >>> Some callers may need to make signaling decisions based on the state >>> of the targeted task, and that can only safely be done post adding >>> the task_work to the task. Split task_work_add() into: >>> >>> __task_work_add() - adds the work item >>> __task_work_notify() - sends the notification >>> >>> No functional changes in this patch. >> >> Might be nice to mention __task_work_add() is now inline. > > OK, will mention that. Added a note of that in the commit message, otherwise the patch is unchanged: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=67e5aca3cb1bd40de0392fea5a661eae2372d6cc Are you happy with this one now, given that we cannot easily make the exit_work const? -- Jens Axboe
