Fwd: [PATCH] xfs: fix bad hash ordering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



My mailer has DHCP so it was rejected by vger. Forwarding for your attention.

--Mark Tinguely <tinguely@xxxxxxx>

-------- Original Message --------
Subject: [PATCH] xfs: fix bad hash ordering
Date: Fri, 28 Mar 2014 12:33:34 -0500
From: Mark Tinguely <tinguely@xxxxxxx>
To: XFS Mailing List <xfs@xxxxxxxxxxx>
CC: Linux Stable <stable@xxxxxxxxxxxxxxx>

Fix the fix directory "bad hash ordering" bug introduced in
commit f5ea1100.

Reported-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
---
A C program that generates this problem can be found at:
 http://oss.sgi.com/archives/xfs/2014-03/msg00373.html

A xfstest for this bug is coming from Hannes Frederic Sowa.

 fs/xfs/xfs_da_btree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/fs/xfs/xfs_da_btree.c
===================================================================
--- a/fs/xfs/xfs_da_btree.c
+++ b/fs/xfs/xfs_da_btree.c
@@ -1295,7 +1295,7 @@ xfs_da3_fixhashpath(
 		node = blk->bp->b_addr;
 		dp->d_ops->node_hdr_from_disk(&nodehdr, node);
 		btree = dp->d_ops->node_tree_p(node);
-		if (be32_to_cpu(btree->hashval) == lasthash)
+		if (be32_to_cpu(btree[blk->index].hashval) == lasthash)
 			break;
 		blk->hashval = lasthash;
 		btree[blk->index].hashval = cpu_to_be32(lasthash);


_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]