On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > > > Hi > > > > Am 07.08.20 um 15:30 schrieb gregkh@xxxxxxxxxxxxxxxxxxx: > > > The patch below was submitted to be applied to the 5.8-stable tree. > > > > > > I fail to see how this patch meets the stable kernel rules as found at > > > Documentation/process/stable-kernel-rules.rst. > > > > > > I could be totally wrong, and if so, please respond to > > > <stable@xxxxxxxxxxxxxxx> and let me know why this patch should be > > > applied. Otherwise, it is now dropped from my patch queues, never to be > > > seen again. > > > > Sorry for the noise. There's no reason this should go into stable. > > We have a little script in our maintainer toolbox for bugfixes, which > generates the Fixes: line, adds everyone from the original commit to > the cc: list and also adds Cc: stable if that sha1 the patch fixes is > in a release already. > > I guess we trained people a bit too much on using Fixes: tags like > that with the tooling, since they often do that for checkpatch stuff > and spelling fixes like this here too. I think the autoselect bot also > loves Fixes: tags a bit too much for its own good. > > Not sure what to do, since telling people to "please sprinkle less > Fixes: tags" doesn't sound great either. I also don't want to tell > people to use the maintainer toolbox less, the autogenerated cc: list > is generally the right thing to do. Maybe best if the stable team > catches the obvious ones before adding them to the stable queue, if > you're ok with that Greg? As I think this is the first time that I've had this problem for a DRM submission, I don't think it's a big issue yet at all, so whatever you are doing today is fine. I do think that the number of patches submitted for stable for drm-related issues feels very very low given the rate of change and number of overall patches you all submit to the kernel, so if anything, you all should be increasing the number of times you tag stuff for stable, not reducing it :) thanks, greg k-h
