On Thu, Aug 6, 2020 at 10:44 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Aug 06, 2020 at 09:42:51AM -0400, Alex Deucher wrote:
> > On Thu, Aug 6, 2020 at 7:10 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Wed, Aug 05, 2020 at 05:57:00PM -0400, Alex Deucher wrote:
> > > > The ordering of psp_tmr_terminate() and psp_asd_unload()
> > > > got reversed when the patches were applied to stable.
> > > >
> > > > Fixes: 22ff658396b446 ("drm/amdgpu: asd function needs to be unloaded in suspend phase")
> > > > Fixes: 2c41c968c6f648 ("drm/amdgpu: add TMR destory function for psp")
> > > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > > > Cc: stable@xxxxxxxxxxxxxxx # 5.7.x
> > > > Cc: Huang Rui <ray.huang@xxxxxxx>
> > > > ---
> > > > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > What is the git commit id of this patch in Linus's tree?
> >
> > It doesn't exist in Linus' tree. The order is correct in 5.8 and
> > newer. The order got reversed when the patches were applied to
> > stable.
>
> Than this needs to be explicitly called out and documented in the patch,
> otherwise we have no idea what is going on...
I'll respin and make it explicit. thanks!
Alex
