On Thu, Mar 27, 2014 at 7:41 AM, Takashi Iwai <tiwai@xxxxxxx> wrote: >> It apparently blows up on some machines. This functionally reverts >> >> commit 828c79087cec61eaf4c76bb32c222fbe35ac3930 >> Author: Ben Widawsky <benjamin.widawsky@xxxxxxxxx> >> Date: Wed Oct 16 09:21:30 2013 -0700 >> >> drm/i915: Disable GGTT PTEs on GEN6+ suspend >> >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64841 >> Reported-and-Tested-by: Brad Jackson <bjackson0971@xxxxxxxxx> >> Cc: stable@xxxxxxxxxxxxxxx >> Cc: Takashi Iwai <tiwai@xxxxxxx> >> Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> >> Cc: Todd Previte <tprevite@xxxxxxxxx> >> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > The commit was the fix for the memory corruption and lock up at S4 on > some (Haswell) machines. This revert will re-introduce the issue > again very likely. I'm going to check with the latest tree, but this > may take some time. > > Wouldn't it be safer to revert this conditionally like I suggested in > comment 10 of the bugzilla entry? I know that this will blow up, but apparently no one from our side really bothered to test stuff or work on this. So regression wins and I've pushed out the revert - this bug has been lingering a bit too long. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html