On Tue, Aug 04, 2020 at 04:19:54PM +0300, Tomi Valkeinen wrote: > On 04/08/2020 16:13, Adam Ford wrote: > > > > > > On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <aford173@xxxxxxxxx <mailto:aford173@xxxxxxxxx>> wrote: > > > > There appears to be a timing issue where using a divider of 32 breaks > > the DSS for OMAP36xx despite the TRM stating 32 is a valid > > number. Through experimentation, it appears that 31 works. > > > > This same fix was issued for kernels 4.5+. However, between > > kernels 4.4 and 4.5, the directory structure was changed when the > > dss directory was moved inside the omapfb directory. That broke the > > patch on kernels older than 4.5, because it didn't permit the patch > > to apply cleanly for 4.4 and older. > > > > A similar patch was applied to the 3.16 kernel already, but not to 4.4. > > Commit 4b911101a5cd ("drm/omap: fix max fclk divider for omap36xx") is > > on the 3.16 stable branch with notes from Ben about the path change. > > > > Since this was applied for 3.16 already, this patch is for kernels > > 3.17 through 4.4 only. > > > > Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev") > > > > Cc: <stable@xxxxxxxxxxxxxxx <mailto:stable@xxxxxxxxxxxxxxx>> #3.17 - 4.4 > > CC: <tomi.valkeinen@xxxxxx <mailto:tomi.valkeinen@xxxxxx>> > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx <mailto:aford173@xxxxxxxxx>> > > > > > > Tomi, > > > > Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed. > > Looks good to me. > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> I don't seem to have the original of this anymore, can someone please resend it? thanks, greg k-h
