Re: [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/3/20 1:46 AM, Hui Wang wrote:
This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow()
for all hda controllers").

The reverted patch already introduced some regressions on some
machines:
  - on gemini-lake machines, the error of "azx_get_response timeout"
    happens in the hda driver.
  - on the machines with alc662 codec, the audio jack detection doesn't
    work anymore.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx>
---
  sound/pci/hda/hda_intel.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index e699873c8293..e34a4d5d047c 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2352,7 +2352,6 @@ static int azx_probe_continue(struct azx *chip)
if (azx_has_pm_runtime(chip)) {
  		pm_runtime_use_autosuspend(&pci->dev);
-		pm_runtime_allow(&pci->dev);
  		pm_runtime_put_autosuspend(&pci->dev);
  	}

Do I get this right that this permanently disables pm_runtime on all Intel HDaudio controllers?




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux