On 8/1/20 10:43 AM, Samuel Holland wrote: > This code attempts to set the HCI_UART_RESET_ON_INIT flag. However, > it sets the bit in the wrong flag word: HCI_UART_RESET_ON_INIT goes in > hu->hdev_flags, not hu->flags. So it is actually setting > HCI_UART_REGISTERED, which is bit 1 in hu->flags. > > Since commit cba736465e5c ("Bluetooth: hci_serdev: Remove setting of > HCI_QUIRK_RESET_ON_CLOSE."), this flag is ignored for hci_serdev users, > so instead of fixing which flag is set, let's remove the flag entirely. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: ce945552fde4 ("Bluetooth: hci_h5: Add support for serdev enumerated devices") > Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> > --- > drivers/bluetooth/hci_h5.c | 2 -- > 1 file changed, 2 deletions(-) Sorry, I didn't see the other patches that were just added to -next. I'll rebase my additional changes on top of them and resend. Regards, Samuel