On Thu, Jul 30, 2020 at 07:22:22PM -0600, Robert Hancock wrote:
> I would like to nominate the following commit, now in mainline, for
> stable. This fixes an issue exposed by commit 66ff14e59e8a ("PCI/ASPM:
> Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges") and so should go
> into all stable branches which that was backported to (which appears
> to be all of the currently maintained releases).
>
> commit b361663c5a40c8bc758b7f7f2239f7a192180e7c
> Author: Robert Hancock <hancockrwd@xxxxxxxxx>
> Date: Tue Jul 21 20:18:03 2020 -0600
>
> PCI/ASPM: Disable ASPM on ASMedia ASM1083/1085 PCIe-to-PCI bridge
>
> Recently ASPM handling was changed to allow ASPM on PCIe-to-PCI/PCI-X
> bridges. Unfortunately the ASMedia ASM1083/1085 PCIe to PCI bridge device
> doesn't seem to function properly with ASPM enabled. On an Asus PRIME
> H270-PRO motherboard, it causes errors like these:
>
> pcieport 0000:00:1c.0: AER: PCIe Bus Error: severity=Corrected,
> type=Data Link Layer, (Transmitter ID)
> pcieport 0000:00:1c.0: AER: device [8086:a292] error
> status/mask=00003000/00002000
> pcieport 0000:00:1c.0: AER: [12] Timeout
> pcieport 0000:00:1c.0: AER: Corrected error received: 0000:00:1c.0
> pcieport 0000:00:1c.0: AER: can't find device of ID00e0
>
> In addition to flooding the kernel log, this also causes the machine to
> wake up immediately after suspend is initiated.
>
> The device advertises ASPM L0s and L1 support in the Link Capabilities
> register, but the ASMedia web page for ASM1083 [1] claims "No PCIe ASPM
> support".
>
> Windows 10 (build 2004) enables L0s, but it also logs correctable PCIe
> errors.
>
> Add a quirk to disable ASPM for this device.
>
> [1] https://www.asmedia.com.tw/eng/e_show_products.php?cate_index=169&item=114
>
> [bhelgaas: commit log]
> Fixes: 66ff14e59e8a ("PCI/ASPM: Allow ASPM on links to
> PCIe-to-PCI/PCI-X Bridges")
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208667
> Link: https://lore.kernel.org/r/20200722021803.17958-1-hancockrwd@xxxxxxxxx
> Signed-off-by: Robert Hancock <hancockrwd@xxxxxxxxx>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Now queued up everywhere, thansk!
greg k-h
