Re: Patch "HID: microsoft: Add ID's for Surface Type/Touch Cover 2" has been added to the 3.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

same reasons than for the 3.13 backport: NACK

Cheers,
Benjamin

On Mar 25 2014 or thereabouts, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     HID: microsoft: Add ID's for Surface Type/Touch Cover 2
> 
> to the 3.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      hid-microsoft-add-id-s-for-surface-type-touch-cover-2.patch
> and it can be found in the queue-3.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> From 117309c51dca42121f70cacec801511b76acf75c Mon Sep 17 00:00:00 2001
> From: Reyad Attiyat <reyad.attiyat@xxxxxxxxx>
> Date: Tue, 28 Jan 2014 16:17:57 +0100
> Subject: HID: microsoft: Add ID's for Surface Type/Touch Cover 2
> 
> From: Reyad Attiyat <reyad.attiyat@xxxxxxxxx>
> 
> commit 117309c51dca42121f70cacec801511b76acf75c upstream.
> 
> The Microsoft Surface Type/Touch cover 2 devices have the flag HID_DG_CONTACTID
> in their reports.This causes the device to bind to the hid-multitouch driver,
> which doesn't handle generic keyboard/mouse input events.  The patch adds
> the hardware id's of the device to hid-microsoft and to the HID special
> driver array, which makes the device get handled by hid-generic/hid-input
> properly.
> 
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=64811
> 
> Singed-off-by: Reyad Attiyat <reyad.attiyat@xxxxxxxxx>
> Reviewed-by: Benjamin Tissoires<benjamin.tissoires@xxxxxxxxxx>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> ---
>  drivers/hid/hid-core.c      |    2 ++
>  drivers/hid/hid-ids.h       |    2 ++
>  drivers/hid/hid-microsoft.c |    4 ++++
>  3 files changed, 8 insertions(+)
> 
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1565,6 +1565,8 @@ static const struct hid_device_id hid_ha
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_USB) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_3K) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_2) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1) },
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -546,6 +546,8 @@
>  #define USB_DEVICE_ID_MS_PRESENTER_8K_USB	0x0713
>  #define USB_DEVICE_ID_MS_DIGITAL_MEDIA_3K	0x0730
>  #define USB_DEVICE_ID_MS_COMFORT_MOUSE_4500	0x076c
> +#define USB_DEVICE_ID_MS_TOUCH_COVER_2	0x07a7
> +#define USB_DEVICE_ID_MS_TYPE_COVER_2	0x07a9
>  
>  #define USB_VENDOR_ID_MOJO		0x8282
>  #define USB_DEVICE_ID_RETRO_ADAPTER	0x3201
> --- a/drivers/hid/hid-microsoft.c
> +++ b/drivers/hid/hid-microsoft.c
> @@ -206,6 +206,10 @@ static const struct hid_device_id ms_dev
>  		.driver_data = MS_NOGET },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_COMFORT_MOUSE_4500),
>  		.driver_data = MS_DUPLICATE_USAGES },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_2),
> +		.driver_data = 0 },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2),
> +		.driver_data = 0 },
>  
>  	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT),
>  		.driver_data = MS_PRESENTER },
> 
> 
> Patches currently in stable-queue which might be from reyad.attiyat@xxxxxxxxx are
> 
> queue-3.4/hid-microsoft-add-id-s-for-surface-type-touch-cover-2.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]