On Tue, Jul 21, 2020 at 11:34:26AM -0400, Michael J. Ruhl wrote:
Thanks for an update, my comments below.
> The !ATOMIC_IOMAP version of io_maping_init_wc will always return
> success, even when the ioremap fails.
>
> Since the ATOMIC_IOMAP version returns NULL when the init fails, and
> callers check for a NULL return on error this is unexpected.
>
> Return NULL on ioremap failure.
>
> Fixes: cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata about the io-mapping"
Missed parenthesis.
Still not visible why Fixes tag.
Provide also couple of lines of crash and add a paragraph about it.
--
With Best Regards,
Andy Shevchenko
