Re: [patch NOT added to the 3.12 stable tree] audit: don't generate loginuid log when audit disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/03/22, Jiri Slaby wrote:
> From: Gao feng <gaofeng@xxxxxxxxxxxxxx>
> 
> This patch does NOT apply to the 3.12 stable tree. If you still want
> it applied, please provide a backport.

It is NOT necessary on 3.12 because the patch that caused the bug this
fixes wasn't backported to 3.12.

> ===============
> 
> commit c2412d91c68426e22add16550f97ae5cd988a159 upstream.
> 
> If audit is disabled, we shouldn't generate loginuid audit
> log.
> 
> Acked-by: Eric Paris <eparis@xxxxxxxxxx>
> Signed-off-by: Gao feng <gaofeng@xxxxxxxxxxxxxx>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
> ---
>  kernel/auditsc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index df1e685809e1..9ab02fa2334c 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1971,6 +1971,9 @@ static void audit_log_set_loginuid(kuid_t koldloginuid, kuid_t kloginuid,
>  	struct audit_buffer *ab;
>  	uid_t uid, ologinuid, nloginuid;
>  
> +	if (!audit_enabled)
> +		return;
> +
>  	uid = from_kuid(&init_user_ns, task_uid(current));
>  	ologinuid = from_kuid(&init_user_ns, koldloginuid);
>  	nloginuid = from_kuid(&init_user_ns, kloginuid),
> -- 
> 1.9.0
> 

- RGB

--
Richard Guy Briggs <rbriggs@xxxxxxxxxx>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]