Re: [PATCH v3 01/12] drm/ingenic: Fix incorrect assumption about plane->index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,

Le jeu. 16 juil. 2020 à 19:43, Sam Ravnborg <sam@xxxxxxxxxxxx> a écrit :
Hi Paul.

On Thu, Jul 16, 2020 at 06:38:35PM +0200, Paul Cercueil wrote:
 plane->index is NOT the index of the color plane in a YUV frame.
Actually, a YUV frame is represented by a single drm_plane, even though
 it contains three Y, U, V planes.

 v2-v3: No change

 Cc: stable@xxxxxxxxxxxxxxx # v5.3
Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
 Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
 Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

A cover letter would have been useful. Please consider that in the
future.
All patches in this set are:
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

A few requires some trivial issues fixed. They can be fixed while
applying.

I consider the patch-set ready to go in and I expect you to commit them.

Great! Thanks!

-Paul

	Sam

 ---
  drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
 index deb37b4a8e91..606d8acb0954 100644
 --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
 +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
@@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
  		addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
  		width = state->src_w >> 16;
  		height = state->src_h >> 16;
 -		cpp = state->fb->format->cpp[plane->index];
 +		cpp = state->fb->format->cpp[0];

  		priv->dma_hwdesc->addr = addr;
  		priv->dma_hwdesc->cmd = width * height * cpp / 4;
 --
 2.27.0






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux