On Thu, Jul 16, 2020 at 02:56:46PM +0200, Paul Cercueil wrote: > The FRD350H54004 panel was marked as having active-high VSYNC and HSYNC > signals, which sorts-of worked, but resulted in the picture fading out > under certain circumstances. > > Fix this issue by marking VSYNC and HSYNC signals active-low. > > v2: Rebase on drm-misc-next > > Fixes: 7b6bd8433609 ("drm/panel: simple: Add support for the Frida FRD350H54004 panel") > Cc: stable@xxxxxxxxxxxxxxx # v5.5 > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> Thanks for the re-submit. Applied both patches to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index f42249b72548..8b0bab9dd075 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1763,7 +1763,7 @@ static const struct drm_display_mode frida_frd350h54004_mode = { > .vsync_start = 240 + 2, > .vsync_end = 240 + 2 + 6, > .vtotal = 240 + 2 + 6 + 2, > - .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > }; > > static const struct panel_desc frida_frd350h54004 = { > -- > 2.27.0