On Mon, Jul 13, 2020 at 02:59:01PM -0400, Sasha Levin wrote:
> On Mon, Jul 13, 2020 at 06:00:59PM +0200, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> >
> > The patch below does not apply to the 5.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@xxxxxxxxxxxxxxx>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > > From 66b7e05dc0239c5817859f261098ba9cc2efbd2b Mon Sep 17 00:00:00 2001
> > From: Steven Price <steven.price@xxxxxxx>
> > Date: Wed, 17 Jun 2020 11:54:56 +0100
> > Subject: [PATCH] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect
> > with SVE
> >
> > If SVE is enabled then 'ret' can be assigned the return value of
> > kvm_vcpu_enable_sve() which may be 0 causing future "goto out" sites to
> > erroneously return 0 on failure rather than -EINVAL as expected.
> >
> > Remove the initialisation of 'ret' and make setting the return value
> > explicit to avoid this situation in the future.
> >
> > Fixes: 9a3cdf26e336 ("KVM: arm64/sve: Allow userspace to enable SVE for vcpus")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reported-by: James Morse <james.morse@xxxxxxx>
> > Signed-off-by: Steven Price <steven.price@xxxxxxx>
> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20200617105456.28245-1-steven.price@xxxxxxx
>
> I've worked around not having 540f76d12c66 ("arm64: cpufeature: Add CPU
> capability for AArch32 EL1 support") in 5.7 and 5.4 and queued this
> patch.
Thanks!
