On Sun, 2020-07-12 at 08:12 -0700, Tom Rix wrote: > On 7/12/20 6:09 AM, H. Peter Anvin wrote: > > On 2020-07-12 05:59, trix@xxxxxxxxxx wrote: > > > From: Tom Rix <trix@xxxxxxxxxx> [] > > > So change the type in sizeof to 'unsigned int' > > You must be kidding. > > > > If you want to change it, change it to sizeof(bd->dbuf) instead, but this flag > > is at least in my opinion a total joke. For sizeof(int) != sizeof(unsigned > > int) is beyond bizarre, no matter how stupid the platform. > > Using the actual type is more correct that using a type of the same size. Sure. But this hardly matters as this same type conversion from signed to unsigned or the other way round is _everywhere_ in the kernel. And especially the cc of stable is unnecessary.
