Re: [PATCH 2/5] module: Refactor section attr into bin attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 2/5] module: Refactor section attr into bin attribute
From: Jessica Yu <jeyu@xxxxxxxxxx>
Date: Wed, 8 Jul 2020 18:10:52 +0200
Cc: Dominik Czarnota <dominik.czarnota@xxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, KP Singh <kpsingh@xxxxxxxxxxxx>, "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxx>, Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>, Dmitry Safonov <0x7f454c46@xxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Masahiro Yamada <masahiroy@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matteo Croce <mcroce@xxxxxxxxxx>, Edward Cree <ecree@xxxxxxxxxxxxxx>, Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>, Alexander Lobakin <alobakin@xxxxxxxx>, Thomas Richter <tmricht@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20200702232638.2946421-3-keescook@chromium.org>
User-agent: Mutt/1.10.1 (2018-07-13)

+++ Kees Cook [02/07/20 16:26 -0700]:

In order to gain access to the open file's f_cred for kallsym visibility
permission checks, refactor the module section attributes to use the
bin_attribute instead of attribute interface. Additionally removes the
redundant "name" struct member.

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>


Hi Kees,

This looks good to me:

Tested-by: Jessica Yu <jeyu@xxxxxxxxxx>
Acked-by: Jessica Yu <jeyu@xxxxxxxxxx>

Thanks!

References:
- [PATCH 2/5] module: Refactor section attr into bin attribute
  - From: Kees Cook

Prev by Date: [PATCH] drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset()
Next by Date: Re: [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object
Previous by thread: Re: [PATCH 2/5] module: Refactor section attr into bin attribute
Next by thread: [PATCH 5/5] bpf: Check correct cred for CAP_SYSLOG in bpf_dump_raw_ok()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]