On Mon, 6 Jul 2020 at 18:01, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > On eviction, we acquire the vm->mutex and then wait on the vma->active. > Thereore when binding and pinning the vma, we must follow the same > sequence, lock/pin the vma then mark it active. Otherwise, we mark the > vma as active, then wait for the vm->mutex, and meanwhile the evictor > holding the mutex waits upon us to complete our activity. > > Fixes: 8ccfc20a7d56 ("drm/i915/gt: Mark ring->vma as active while pinned") > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # v5.6+ Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>