Hi Chris, On Thu, Jul 02, 2020 at 10:10:15PM +0100, Chris Wilson wrote: > Not only do we need to release the vm.ref we acquired for the vma on the > duplicate insert branch, but also for the normal error paths, so roll > them all into one. > > Reported-by: Andi Shyti <andi.shyti@xxxxxxxxx> > Suggested-by: Andi Shyti <andi.shyti@xxxxxxxxx> > Fixes: 2850748ef876 ("drm/i915: Pull i915_vma_pin under the vm->mutex") > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Andi Shyti <andi.shyti@xxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # v5.5+ I've never been mentioned this much before, not even at school. But that's not enough and I'll give myself another mention: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxx> Andi