Antwort: Re: [PATCH v2] net: bridge: enfore alignment for ethernet address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




-----netdev-owner@xxxxxxxxxxxxxxx schrieb: -----

>An: t.martitz@xxxxxx
>Von: "David Miller" 
>Gesendet von: netdev-owner@xxxxxxxxxxxxxxx
>Datum: 25.06.2020 21:38
>Kopie: netdev@xxxxxxxxxxxxxxx, roopa@xxxxxxxxxxxxxxxxxxx,
>nikolay@xxxxxxxxxxxxxxxxxxx, kuba@xxxxxxxxxx, nbd@xxxxxxxx,
>stable@xxxxxxxxxxxxxxx
>Betreff: Re: [PATCH v2] net: bridge: enfore alignment for ethernet
>address
>
>From: Thomas Martitz <t.martitz@xxxxxx>
>Date: Thu, 25 Jun 2020 14:26:03 +0200
>
>> The eth_addr member is passed to ether_addr functions that require
>> 2-byte alignment, therefore the member must be properly aligned
>> to avoid unaligned accesses.
>> 
>> The problem is in place since the initial merge of multicast to
>unicast:
>> commit 6db6f0eae6052b70885562e1733896647ec1d807 bridge: multicast
>to unicast
>> 
>> Fixes: 6db6f0eae605 ("bridge: multicast to unicast")
>> Cc: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx>
>> Cc: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
>> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
>> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
>> Cc: Felix Fietkau <nbd@xxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Thomas Martitz <t.martitz@xxxxxx>
>
>Applied and queued up for -stable.

Awesome, thank you! I was about to resend the patch with the Nikolay's
Acked-By, but turns out that wasn't necessary.

>
>Please do not explicitly CC: stable for networking changes, I take
>care
>of those by hand.
>

Alright, I'll remeber that. This was my very first submission to the kernel,
everywhere it is suggested to Cc: stable.

Best regards.




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux