On Tue, Jun 23, 2020 at 11:11:03PM +0200, Pavel Machek wrote:
Hi!
[ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ]
The error handling flow seems incorrect, there is no reason to try and
add debugfs support if the device registration did not
succeed. Return on error.
+++ b/drivers/soundwire/slave.c
@@ -55,6 +55,8 @@ static int sdw_slave_add(struct sdw_bus *bus,
list_del(&slave->node);
mutex_unlock(&bus->bus_lock);
put_device(&slave->dev);
+
+ return ret;
}
return ret;
Mainline is significantly different here; this patch does not make
sense in v4.19 -- as it does not do anything.
I've dropped it from 4.19, thanks!
--
Thanks,
Sasha
