On 19 March 2014 23:55, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Mar 17, 2014 at 06:30:38PM +0000, Steve Capper wrote: >> Page table entries on ARM64 are 64 bits, and some pte functions such as >> pte_dirty return a bitwise-and of a flag with the pte value. If the >> flag to be tested resides in the upper 32 bits of the pte, then we run >> into the danger of the result being dropped if downcast. >> >> For example: >> gather_stats(page, md, pte_dirty(*pte), 1); >> where pte_dirty(*pte) is downcast to an int. >> >> This patch adds a double logical invert to all the pte_ accessors to >> ensure predictable downcasting. >> >> Cc: <stable@xxxxxxxxxxxxxxx> >> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx> >> [steve.capper@xxxxxxxxxx: rebased patch to leave pte_write alone to >> allow for merge with 3.13 stable] >> Signed-off-by: Steve Capper <steve.capper@xxxxxxxxxx> >> --- >> This is a rebase of: >> 84fe682 arm64: mm: Add double logical invert to pte accessors >> >> It was CC stable, but had a merge conflict around pte_write when >> applied to 3.13-stable. >> >> I've fixed the merge conflict for 3.13 and given it a quick test. >> --- >> arch/arm64/include/asm/pgtable.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) > > What is the git commit id of this patch in Linus's tree? Hi Greg, The full id is: 84fe6826c28f69d8708bd575faed7f75e6b6f57f Cheers, -- Steve -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html