On Tuesday, June 06/09/20, 2020 at 00:05:33 +0900, Keith Busch wrote: > On Mon, Jun 08, 2020 at 12:05:44PM +0530, Dakshaja Uppalapati wrote: > > On Friday, June 06/05/20, 2020 at 15:43:40 +0200, Greg KH wrote: > > > On Wed, Jun 03, 2020 at 02:48:51PM +0530, Dakshaja Uppalapati wrote: > > > > This reverts upstream 'commit 530436c45ef2 > > > > ("nvme: Discard workaround for non-conformant devices")' > > > > > > > > Since commit `530436c45ef2` introduced a regression due to which > > > > blk_update_request IO error is observed on formatting device, reverting it. > > > > > > > > Fixes: 530436c45ef2 ("nvme: Discard workaround for non-conformant devices") > > > > Cc: stable <stable@xxxxxxxxxxxxxxx> # 4.19+ > > > > Signed-off-by: Dakshaja Uppalapati <dakshaja@xxxxxxxxxxx> > > > > --- > > > > drivers/nvme/host/core.c | 12 +++--------- > > > > 1 file changed, 3 insertions(+), 9 deletions(-) > > > > > > This was only for stable? > > > > > > > Yes this is for stable 5.4 and 4.19 branches > > No, this revert needs to be rejected. The stable patches need to be the > upstream equivalent. Hi keith, I have sent the required patches which are need to pulled from upstream to stable 5.4 and 4.19 branches. Please let me know if you need any further info. Thanks, Dakshaja