On Fri, Jun 05, 2020 at 07:31:35PM +0200, Hans de Goede wrote: > On 6/5/20 7:09 PM, Andy Shevchenko wrote: > > On Fri, Jun 05, 2020 at 04:33:47PM +0200, Hans de Goede wrote: > > > On 6/2/20 5:23 PM, Andy Shevchenko wrote: > > > > On Tue, Jun 02, 2020 at 02:21:30PM +0200, Hans de Goede wrote: ... > > > Sure, not sure if that is worth respinning the patch for though, > > > either way let me know. > > > > I think makes sense to respin. We still have time. > > I wasn't talking about timing, more just that it creates extra > work (for me) and if that was just for the capital 'B' thingie it > would not be worth the extra work IMHO, but since we need a v2 for > the fixes tag anyways I'll fix this as well. I got your point, no problem, I would fix myself, if it is only the comment to address. ... > > Btw, can we for sake of consistency update direction_input() as well? > > Sure, the change for that will be quite small, so shall I out it > in this patch, or do you want a second patch for that? I think we can do in one. -- With Best Regards, Andy Shevchenko
