Re: [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 03, 2020 at 09:47:18PM +0530, Dakshaja Uppalapati wrote:
> > Err, why?  Please send an actual bug report with details of your
> > setup.
> 
> Hi Christoph,
> 
> Here is the link describing the issue initially reported for upstream 
> kernel 5.5:
> 
> https://lore.kernel.org/linux-nvme/CH2PR12MB40053A64681EFA3E6F63FDFBDD2A0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> 
> Issue is later fixed with upstream commit b716e688.

We are talking about two different things here.  One is the Linux NVMe
host code that can be used with lots of different controllers.  Many of
them are PCIe controller, especially cheap ones.

The other is the Linux NVMe target code.  So if a fix for very common
PCIe controller trigger a bug in the target code there is no 1:1
relationship as even if you are talking to a Linux fabrics controller
it usually runs a different kernel version on a different system.

That being said you can always backport that fix as well, which probably
is a good idea as it fixes a real bug.

Nevermind that nothing in your revert patch indicated it wasn't for
mainline.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux