Re: [PATCH] x86_pkg_temp_thermal: Do not expose as a hwmon device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luís,

On Tue, 11 Mar 2014 10:06:47 +0000, Luís Henriques wrote:
> On Mon, Mar 10, 2014 at 06:42:27PM +0100, Jean Delvare wrote:
> > I believe that this commit:
> > 
> > commit 79786880a47a8c5b4c8146c03432b3387a07a169
> > Author: Jean Delvare <jdelvare@xxxxxxx>
> > Date:   Sun Mar 2 15:33:35 2014 +0100
> > 
> >     x86_pkg_temp_thermal: Do not expose as a hwmon device
> >     
> >     The temperature value reported by x86_pkg_temp_thermal is already
> >     reported by the coretemp driver. So, do not expose this thermal zone
> >     as a hwmon device, because it would be redundant.
> > 
> > should go into stable kernel trees 3.13 and 3.12. The above commit
> > message doesn't make it obvious, but the driver uses a non-standard
> > hwmon device name attribute, which confuses libsensors.
> 
> Thanks.  Looks like this could also be applied to the 3.11 kernel.  Unless
> anyone has an objection, I'll queue it for this kernel as well.

The no_hwmon flag was added in kernel 3.12 so the patch will cause a
build failure on older kernels. This is the reason why I suggested to
apply only to 3.12 and up. If you really want this in 3.11 then you'll
have to backport commit ccba4ffd9eff6120a20cc7656458ac554aec4b0c
(drivers: thermal: make usage of CONFIG_THERMAL_HWMON optional) first.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]