From: Artem Fetishev <artem_fetishev@xxxxxxxx>
Subject: fs/proc/base.c: fix GPF in /proc/$PID/map_files
The expected logic of proc_map_files_get_link() is either to return 0 and
initialize 'path' or return an error and leave 'path' uninitialized. By
the time dname_to_vma_addr() returns 0 the corresponding vma may have
already be gone. In this case the path is not initialized but the return
value is still 0. This results in 'general protection fault' inside
d_path().
Steps to reproduce:
CONFIG_CHECKPOINT_RESTORE=y
fd = open(...);
while (1) {
mmap(fd, ...);
munmap(fd, ...);
}
ls -la /proc/$PID/map_files
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=68991
Signed-off-by: Artem Fetishev <artem_fetishev@xxxxxxxx>
Signed-off-by: Aleksandr Terekhov <aleksandr_terekhov@xxxxxxxx>
Reported-by: <wiebittewas@xxxxxxxxx>
Acked-by: Pavel Emelyanov <xemul@xxxxxxxxxxxxx>
Acked-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/proc/base.c | 1 +
1 file changed, 1 insertion(+)
diff -puN fs/proc/base.c~fs-proc-basec-fix-gpf-in-proc-pid-map_files fs/proc/base.c
--- a/fs/proc/base.c~fs-proc-basec-fix-gpf-in-proc-pid-map_files
+++ a/fs/proc/base.c
@@ -1824,6 +1824,7 @@ static int proc_map_files_get_link(struc
if (rc)
goto out_mmput;
+ rc = -ENOENT;
down_read(&mm->mmap_sem);
vma = find_exact_vma(mm, vm_start, vm_end);
if (vma && vma->vm_file) {
_
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html