Re: [PATCH] vmxnet3: fix netpoll race condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 07, 2014 at 09:14:21PM -0800, Shreyas Bhatewara wrote:
> Thanks for the patch Neil. 
> 
> 
> > --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> > @@ -1762,11 +1762,13 @@ vmxnet3_netpoll(struct net_device *netdev)
> >  {
> >  	struct vmxnet3_adapter *adapter = netdev_priv(netdev);
> >  
> > -	if (adapter->intr.mask_mode == VMXNET3_IMM_ACTIVE)
> > -		vmxnet3_disable_all_intrs(adapter);
> > -
> > -	vmxnet3_do_poll(adapter, adapter->rx_queue[0].rx_ring[0].size);
> > -	vmxnet3_enable_all_intrs(adapter);
> > +	switch (adapter->intr.type) {
> > +	case VMXNET3_IT_MSIX:
> > +		vmxnet3_msix_rx(0, &adapter->rx_queue[0]);
> 
> This should be called for each rx queue, just calling it for
> 1st queue does not suffice.
You're right, I'll fix that up.

> Also there should be a break; here
> 
that too. thanks
Neil

> 
> > +	case VMXNET3_IT_MSI:
> > +	default:
> > +		vmxnet3_intr(0, adapter->netdev);
> > +	}
> 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]