On Fri, May 22, 2020 at 04:02:26PM +0200, Peter Zijlstra wrote:
> On Thu, May 21, 2020 at 11:55:21AM -0400, Joel Fernandes wrote:
> > On Thu, May 21, 2020 at 11:53 AM Joel Fernandes (Google)
> > <joel@xxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On a modern Linux distro, compiling the following program fails:
> > > #include<stdlib.h>
> > > #include<stdint.h>
> > > #include<pthread.h>
> > > #include<linux/sched/types.h>
> > >
> > > void main() {
> > > struct sched_attr sa;
> > >
> > > return;
> > > }
> > >
> > > with:
> > > /usr/include/linux/sched/types.h:8:8: \
> > > error: redefinition of ‘struct sched_param’
> > > 8 | struct sched_param {
> > > | ^~~~~~~~~~~
> > > In file included from /usr/include/x86_64-linux-gnu/bits/sched.h:74,
> > > from /usr/include/sched.h:43,
> > > from /usr/include/pthread.h:23,
> > > from /tmp/s.c:4:
> > > /usr/include/x86_64-linux-gnu/bits/types/struct_sched_param.h:23:8:
> > > note: originally defined here
> > > 23 | struct sched_param
> > > | ^~~~~~~~~~~
> > >
> > > This is also causing a problem on using sched_attr Chrome. The issue is
> > > sched_param is already provided by glibc.
> > >
> > > Guard the kernel's UAPI definition of sched_param with __KERNEL__ so
> > > that userspace can compile.
> > >
> > > Signed-off-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>
> >
> > If it is more preferable, another option is to move sched_param to
> > include/linux/sched/types.h
>
> Yeah, not sure. Ingo, you got a preference?
>
> Also, this very much misses a Fixes tag.
Ok, will add Fixe: tag as follows:
Fixes: e2d1e2aec572a ("sched/headers: Move various ABI definitions to <uapi/linux/sched/types.h>")
thanks,
- Joel
