Re: [PATCH] ext4: fix race between ext4_sync_parent() and rename()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 06, 2020 at 11:31:40AM -0700, Eric Biggers wrote:
>  		/*
>  		 * The directory inode may have gone through rmdir by now. But
>  		 * the inode itself and its blocks are still allocated (we hold
> -		 * a reference to the inode so it didn't go through
> -		 * ext4_evict_inode()) and so we are safe to flush metadata
> -		 * blocks and the inode.
> +		 * a reference to the inode via its dentry), so it didn't go
> +		 * through ext4_evict_inode()) and so we are safe to flush
> +		 * metadata blocks and the inode.
>  		 */
>  		ret = sync_mapping_buffers(inode->i_mapping);

Just realized that in this comment, the closing parenthesis I added after
"dentry" shouldn't be there.  Ted, feel free to fix this if you're so inclined.

- Eric



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux