--On March 06, 2014 13:57 +0530 Mugunthan V N <mugunthanvnm@xxxxxx> wrote:
On Wednesday 05 March 2014 03:55 PM, Christian Riesch wrote:
In commit 6892b41d9701283085b655c6086fb57a5d63fa47
Author: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
Date: Tue Jun 25 21:24:51 2013 +0530
net: davinci: emac: Convert to devm_* api
the call of request_irq is replaced by devm_request_irq and the call
of free_irq is removed. But since interrupts are requested in
emac_dev_open, doing ifconfig up/down on the board requests the
interrupts again each time, causing devm_request_irq to fail.
This patch reverts said commit partially: It changes the driver back
to use request_irq instead of devm_request_irq, puts free_irq back in
place, but keeps the remaining changes of the original patch.
Reported-by: Jon Ringle <jon@xxxxxxxxxx>
Signed-off-by: Christian Riesch <christian.riesch@xxxxxxxxxx>
Cc: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Instead of moving back to request irq. can you move the devm interrupt
request code from open to probe so that the issue is fixed, IRQ will be
requested on module insert and IRQ will be free in module remove and
there will not be any failures in devm request irq while repeating
ifup/ifdown and also during module insert/remove.
This is exactly what I tried first, please have a look at my first patch
and the discussion [1]. Florian Fainelli asked me to revert Prabhakar's
patch instead to bring back the "usual situation", "just in case some
uncontrolled interrupt bit triggers an interrupt while the interface is
down for instance..."
Florian Fainelli, Mugunthan VN, which solution is better?
Regards, Christian
[1] http://marc.info/?t=139394310200001&r=1&w=2
Regards
Mugunthan V N
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html