Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/05/2014 03:00 PM, Joe Perches wrote:
On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
Change "dummy supplies not allowed" error message to warning instead,
as this is a just warning message with no change to the behavior.
[]
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
[]
@@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
  		rdev = dummy_regulator_rdev;
  		goto found;
  	} else {
-		dev_err(dev, "dummy supplies not allowed\n");
+		dev_warn(dev, "dummy supplies not allowed\n");

What does this mean anyway?

Would it be better to emit the calling function too with
%pf, __builtin_return_address(0)?


Maybe. In that case, that change has to first go into the mainline. This is a back port of an upstream commit to get rid of a regression in error messages.

-- Shuah

--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]