On Wed, May 06, 2020 at 04:14:51PM -0700, Sagi Grimberg wrote:
> When the controller is reconnecting, the host fails I/O and admin
> commands as the host cannot reach the controller. ns scanning may
> revalidate namespaces during that period and it is wrong to remove
> namespaces due to these failures as we may hang (see 205da2434301).
>
> One command that may fail is nvme_identify_ns_descs. Since we return
> success due to having ns descriptor list optional, we continue to
> validate ns identifiers in nvme_revalidate_disk, obviously fail and
> return -ENODEV to nvme_validate_ns, which will remove the namespace.
>
> Exactly what we don't want to happen.
>
> Fixes: 22802bf742c2 ("nvme: Namepace identification descriptor list is optional")
> Tested-by: Anton Eidelman <anton@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
>
> Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What is the git commit id of this patch in Linus's tree?
And why sign-off on a patch twice with a blank line?
thanks,
greg k-h
