Re: FAILED: patch "[PATCH] irqchip: orion: clear bridge cause register on init" failed to apply to 3.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/04/14 19:12, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
The patch below does not apply to the 3.10-stable tree.
[...]
------------------ original commit in Linus's tree ------------------

 From 7b119fd1bdc59a8060df5b659b9f7a70e0169fd6 Mon Sep 17 00:00:00 2001
From: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
Date: Thu, 23 Jan 2014 23:38:04 +0100
Subject: [PATCH] irqchip: orion: clear bridge cause register on init

It is good practice to mask and clear pending irqs on init. We already
mask all irqs, so also clear the bridge irq cause register.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
Tested-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v3.10+

Greg,

I checked stable/linux-v3.10.y and there is no
drivers/irqchip/irq-orion.c. I guess, above line should have been
'# v3.11+'.

Please drop the three offending 'irqchip: orion:' patches from
3.10-stable.

Sorry for the noise,
  Sebastian

Signed-off-by: Jason Cooper <jason@xxxxxxxxxxxxxx>

diff --git a/drivers/irqchip/irq-orion.c b/drivers/irqchip/irq-orion.c
index e51d40031884..4137c3d15284 100644
--- a/drivers/irqchip/irq-orion.c
+++ b/drivers/irqchip/irq-orion.c
@@ -180,8 +180,9 @@ static int __init orion_bridge_irq_init(struct device_node *np,
  	gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit;
  	gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit;

-	/* mask all interrupts */
+	/* mask and clear all interrupts */
  	writel(0, gc->reg_base + ORION_BRIDGE_IRQ_MASK);
+	writel(0, gc->reg_base + ORION_BRIDGE_IRQ_CAUSE);

  	irq_set_handler_data(irq, domain);
  	irq_set_chained_handler(irq, orion_bridge_irq_handler);


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]