On 4/24/20 8:02 AM, Greg Kroah-Hartman wrote:
> On Fri, Apr 24, 2020 at 07:02:18AM -0700, Guenter Roeck wrote:
>> On Fri, Apr 24, 2020 at 12:11:18PM +0200, Greg Kroah-Hartman wrote:
>>> On Wed, Apr 22, 2020 at 12:43:06PM -0700, Guenter Roeck wrote:
>>>
>> [ ... ]
>>>>
>>>> Upstream commit ce4e45842de3 ("crypto: mxs-dcp - make symbols 'sha1_null_hash' and 'sha256_null_hash' static")
>>>> upstream: v4.20-rc1
>>>> Fixes: c709eebaf5c5 ("crypto: mxs-dcp - Fix SHA null hashes and output length")
>>>> in linux-4.4.y: 33378afbd12b
>>>> in linux-4.9.y: df1ef6f3c9ad
>>>> in linux-4.14.y: c0933fa586b4
>>>> in linux-4.19.y: 70ecd0459d03
>>>> upstream: v4.20-rc1
>>>> Affected branches:
>>>> linux-4.4.y
>>>> linux-4.9.y
>>>> linux-4.14.y
>>>> linux-4.19.y
>>>
>>> That's really not a "bug", but I'll take it to keep your scripts happy.
>>>
>> No need to do that - if it happens please let me know and feel free to
>> drop. The script finds lots of irrelevant patches which are (often
>> unnecessarily) marked as Fixes: (maybe we should have a rule stating that
>> comment changes or documentation changes don't count as "fix"). I already
>> drop a lot of them, and feedback like this helps me decide what to drop
>> in the future.
>>
>> In this case I kept the patch in the list not for the happiness of the
>> script but for the happiness of static analyzers. While it doesn't fix
>> a bug per se, it reduces the noise produced by those, which I think does
>> help because less noise improves focus on real bugs.
>
> Yes it does, good point, but I don't want to start backporting all
> sparse warning fixes to stable kernels just yet :)
>
NP, I'll drop those in the future.
Thanks,
Guenter
