Hi, Gerd On Tue, Mar 31, 2020 at 10:53 PM Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > On Tue, Mar 31, 2020 at 02:18:08PM +0800, Huacai Chen wrote: > > The command ring and cursor ring use different notify port addresses > > definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in > > qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring > > and cursor ring. This doesn't cause any problems now, because QEMU's > > behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. > > However, QEMU's behavior may be change in future, so let's fix it. > > > > P.S.: In the X.org QXL driver, the notify port address of cursor ring > > is correct. > > > > Cc: <stable@xxxxxxxxxxxxxxx> > > Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx> > > Pushed to drm-misc-next. It seems that this patch hasn't appear in upstream. > > thanks, > Gerd > Thanks, Huacai
